Fix regressions in env baking#2746
Conversation
…ked floats in env backer
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new supportPackedFloat parameter to the getBestColorTargetFormat method in the Renderer interface, allowing for more granular control over color format selection. Existing calls in EnvironmentCamera and GenericEnvBaker have been updated to explicitly disable packed float support. The review feedback suggests adding Javadoc to the new public API methods for better documentation and highlights a logic error where the withAlpha requirement was ignored when selecting the RGB111110F format.
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
|
Please review @gemini-code-assist |
riccardobl
changed the title
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request updates the Renderer interface by adding a supportPackedFloat parameter to the getBestColorTargetFormat method and refining the logic to better respect alpha requirements and precision levels. Feedback identifies a bug in IBLGLEnvBakerLight where setting withAlpha to false breaks calculations that depend on the alpha channel. Additionally, the reviewer pointed out that HDR remapping and warnings should only be applied when the system falls back to RGBA8, as 16-bit float formats provide sufficient precision.
riccardobl
changed the title
1 participant
Uh oh!
There was an error while loading. Please reload this page.